forked from NVIDIA/Megatron-LM
-
Notifications
You must be signed in to change notification settings - Fork 0
[4/4] Merge Megatron-RL into LM #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tdene
wants to merge
163
commits into
lmcafee-nvidia:lmcafee/dedupe-engine-coordinator
Choose a base branch
from
tdene:tde/rl_4_out_of_4
base: lmcafee/dedupe-engine-coordinator
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[4/4] Merge Megatron-RL into LM #2
tdene
wants to merge
163
commits into
lmcafee-nvidia:lmcafee/dedupe-engine-coordinator
from
tdene:tde/rl_4_out_of_4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dimapihtar <[email protected]> Co-authored-by: oliver könig <[email protected]>
Co-authored-by: oliver könig <[email protected]>
…rch change (NVIDIA#1924) Signed-off-by: Youngeun Kwon <[email protected]> Signed-off-by: Youngeun <[email protected]> Co-authored-by: oliver könig <[email protected]>
Signed-off-by: oliver könig <[email protected]>
Co-authored-by: Mcore Bot <[email protected]> Co-authored-by: oliver könig <[email protected]>
Signed-off-by: Maanu Grover <[email protected]>
1ac9df6 to
f93bd12
Compare
Co-authored-by: Lawrence McAfee <[email protected]> Co-authored-by: oliver könig <[email protected]>
Signed-off-by: oliver könig <[email protected]> Co-authored-by: AJ Schmidt <[email protected]>
Signed-off-by: oliver könig <[email protected]>
Signed-off-by: oliver könig <[email protected]>
Signed-off-by: oliver könig <[email protected]>
Signed-off-by: oliver könig <[email protected]>
Signed-off-by: ykarnati <[email protected]>
Signed-off-by: Deepak Narayanan <[email protected]>
Signed-off-by: oliver könig <[email protected]>
Signed-off-by: oliver könig <[email protected]>
Signed-off-by: oliver könig <[email protected]>
Signed-off-by: oliver könig <[email protected]>
Signed-off-by: oliver könig <[email protected]>
Signed-off-by: oliver könig <[email protected]>
Signed-off-by: oliver könig <[email protected]>
Signed-off-by: oliver könig <[email protected]>
Signed-off-by: oliver könig <[email protected]>
1258d36 to
c1726bc
Compare
This reverts commit c1726bc.
Signed-off-by: oliver könig <[email protected]>
This reverts commit 0634924.
Signed-off-by: Pablo Garay <[email protected]>
Updated the default baseline commit hash for checks.
…turning the running loop
… tde/rl_4_out_of_4
Signed-off-by: Ananth Subramaniam <[email protected]> Co-authored-by: Jared Casper <[email protected]>
…VIDIA#2008) Signed-off-by: Keshav Santhanam <[email protected]>
Signed-off-by: Asha Anoosheh <[email protected]>
…ate (NVIDIA#2183) Signed-off-by: Keshav Santhanam <[email protected]>
Signed-off-by: dimapihtar <[email protected]>
Check-breaking was force merged given special circumstances/special need (requested to me directly)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Draft. Will update description.
Contribution process
flowchart LR A[Pre-checks] --> B[PR Tests] subgraph Code Review/Approval C1[Expert Review] --> C2[Final Review] end B --> C1 C2 --> D[Merge]Pre-checks
Core 0.8)Code review
The following process is enforced via the CODEOWNERS file for changes into
megatron/core. For changes outside ofmegatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.For MRs into `main` branch
(Step 1): Add PR label
Expert Review(Step 2): Collect the expert reviewers reviews
Expert Reviewlabel when your PR is ready for review.Final Review might get declined if these requirements are not fulfilled.
(Step 3): Final Review
Final Reviewlabel(Optional Step 4): Cherry-pick into release branch
If this PR also needs to be merged into
core_r*release branches, after this PR has been merged, selectCherry-pickto open a new PR into the release branch.For MRs into `dev` branch
The proposed review process for `dev` branch is under active discussion.MRs are mergable after one approval by either
[email protected]or[email protected].Merging your PR
Any member of core-adlr and
core-nemowill be able to merge your PR.