Skip to content

Conversation

@tdene
Copy link

@tdene tdene commented Oct 28, 2025

What does this PR do ?

Draft. Will update description.

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]
Loading

Pre-checks

  • I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either [email protected] or [email protected].

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

@tdene tdene force-pushed the tde/rl_4_out_of_4 branch from 1ac9df6 to f93bd12 Compare October 29, 2025 09:52
tdene and others added 22 commits October 29, 2025 11:38
Co-authored-by: Lawrence McAfee <[email protected]>
Co-authored-by: oliver könig <[email protected]>
Signed-off-by: oliver könig <[email protected]>
Co-authored-by: AJ Schmidt <[email protected]>
@tdene tdene force-pushed the tde/rl_4_out_of_4 branch from 1258d36 to c1726bc Compare November 20, 2025 22:18
tdene and others added 28 commits November 20, 2025 16:20
Updated the default baseline commit hash for checks.
Signed-off-by: Ananth Subramaniam <[email protected]>
Co-authored-by: Jared Casper <[email protected]>
Check-breaking was force merged given special circumstances/special need (requested to me directly)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.