Allow binaries to be in a subdir (x64/x86)#1503
Open
idanmiara wants to merge 5 commits intolmbelo:masterfrom
Open
Allow binaries to be in a subdir (x64/x86)#1503idanmiara wants to merge 5 commits intolmbelo:masterfrom
idanmiara wants to merge 5 commits intolmbelo:masterfrom
Conversation
idanmiara
force-pushed
the
feat/bin_subdir_support
branch
from
41a7107 to
374af0a
Compare
…d change the build dir to x86/x64 subdir
idanmiara
force-pushed
the
feat/bin_subdir_support
branch
from
374af0a to
33b10fb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the only difference between the x86 and the x64 builds are the app exe and WebView2Loader.dll files.
This PR adds an option to release both versions together (i.e. x64 bins in
x64subdir and x86 bins inx86subdir).This also make the dll post build copy event redundant.
.gitignore is updated to include
.idea(unrelated but helpful for using git with PyCharm for this project)