add tests for rcp #269
Open
add tests for rcp #269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Icohedron
reviewed
Jul 11, 2025
bogner
approved these changes
Jul 15, 2025
…from ulp to epsilon to allow for larger differences
Icohedron
approved these changes
Jul 25, 2025
bob80905
reviewed
Jul 25, 2025
There was a problem hiding this comment.
2 things.
- According to the issue, it looks like we should also test 32 and 64 bit int types, is that unnecessary?
- For division by 0, direct3dhlsl specs don't seem to specify that the expected result is inf. I could imagine some implementations might return a nan instead. Even though inf seems to work now, is this a case we want to include in these tests, or, like with previous tests, should we abstain from testing for nans / infs?
test/Feature/HLSLLib/rcp.64.test
Outdated
| [numthreads(1,1,1)] | ||
| void main() { | ||
| Out[0] = rcp(In[0]); | ||
| float4 Tmp = {rcp(In[1].xyz), rcp(In[1].w)}; |
There was a problem hiding this comment.
Don't we want these to be doubles? like double4 rather than float4?
the body of the issue never got updated; it only supports floats. Yeah I guess we could remove the dvision by zero case; |
bob80905
approved these changes
Jul 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add 16, 32, and 64 bit float tests for rcp
closes #127