Skip to content

[clang][FMV] Pass the '+fmv' target-feature when FMV is enabled. #87942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[clang][FMV] Pass the '+fmv' target-feature when FMV is enabled. #87942

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
38eea2e
[clang][FMV] Pass the '+fmv' target-feature when FMV is enabled.
labrinea Apr 7, 2024
0578ec0
Merge branch 'main' into fmv-target-feature
labrinea Nov 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions clang/lib/Driver/ToolChains/Clang.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8027,13 +8027,14 @@ void Clang::ConstructJob(Compilation &C, const JobAction &JA,

addOutlineAtomicsArgs(D, getToolChain(), Args, CmdArgs, Triple);

if (Triple.isAArch64() &&
(Args.hasArg(options::OPT_mno_fmv) ||
(Triple.isAndroid() && Triple.isAndroidVersionLT(23)) ||
getToolChain().GetRuntimeLibType(Args) != ToolChain::RLT_CompilerRT)) {
// Disable Function Multiversioning on AArch64 target.
if (Triple.isAArch64()) {
CmdArgs.push_back("-target-feature");
CmdArgs.push_back("-fmv");
if (Args.hasArg(options::OPT_mno_fmv) ||
(Triple.isAndroid() && Triple.isAndroidVersionLT(23)) ||
getToolChain().GetRuntimeLibType(Args) != ToolChain::RLT_CompilerRT)
CmdArgs.push_back("-fmv");
else
CmdArgs.push_back("+fmv");
}

if (Args.hasFlag(options::OPT_faddrsig, options::OPT_fno_addrsig,
Expand Down
1 change: 1 addition & 0 deletions clang/test/Driver/aarch64-features.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@

// CHECK-FMV-OFF: "-target-feature" "-fmv"
// CHECK-FMV-NOT: "-target-feature" "-fmv"
// CHECK-FMV: "-target-feature" "+fmv"

// Check for AArch64 out-of-line atomics default settings.
// RUN: %clang --target=aarch64-linux-android -rtlib=compiler-rt \
Expand Down
Loading