Skip to content

Update test added in #154418 to work when the default is C++20. #154463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 20, 2025
Merged

Update test added in #154418 to work when the default is C++20. #154463

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0a7441d
Fix test added in #154418 to work when the default is C++20.
dyung Aug 20, 2025
326104d
Update test according to review suggestions.
dyung Aug 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions clang/test/SemaTemplate/nested-name-spec-template.cpp
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can add -std=c++17 and change -verify to -verify=expected,cxx17 so that we can use // cxx17-warning {{...}} instead of adding #if block for some test cases. See https://clang.llvm.org/docs/InternalsManual.html#testing.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's also better than disabling the test, but we don't need to test that we produce this warning, this test is not about that. It's a regression test for a crash and the warning is irrelevant.

Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// RUN: %clang_cc1 -fsyntax-only -verify %s
// RUN: %clang_cc1 -fsyntax-only -verify %s -Wno-c++20-extensions
// RUN: %clang_cc1 -fsyntax-only -verify -std=c++98 %s
// RUN: %clang_cc1 -fsyntax-only -verify -std=c++11 %s

Expand Down Expand Up @@ -174,7 +174,6 @@ namespace SubstTemplateTypeParmPackType {

template <class... Ts> void f() {
[]<int ... Is>(A<Is...>) { (Ts::g(Is) && ...); }(A<0>{});
// expected-warning@-1 {{explicit template parameter list for lambdas is a C++20 extension}}
};

struct B { static void g(int); };
Expand Down