Skip to content

[FMV][GlobalOpt] Do not statically resolve non-FMV callers. #123383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 17, 2025
Merged

[FMV][GlobalOpt] Do not statically resolve non-FMV callers. #123383

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8e061e9
[FMV][GlobalOpt] Do not statically resolver non-FMV callers.
labrinea Jan 17, 2025
8a3d433
Update GlobalOpt.cpp
labrinea Jan 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions llvm/lib/Transforms/IPO/GlobalOpt.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2785,8 +2785,16 @@ static bool OptimizeNonTrivialIFuncs(
} else {
// We can't reason much about non-FMV callers. Just pick the highest
// priority callee if it matches, otherwise bail.
if (I > 0 || !implies(CallerBits, CalleeBits))
continue;
// if (I > 0 || !implies(CallerBits, CalleeBits))
//
// FIXME: This is causing a regression in the llvm test suite,
// specifically a 'predres' version is unexpectedly trapping on
// GravitonG4. My explanation is that when the caller in not a
// versioned function, the compiler exclusively relies on the
// command line option, or target attribute to deduce whether a
// feature is available. However, there is no guarantee that in
// reality the host supports those implied features.
continue;
}
auto &Calls = CallSites[Caller];
for (CallBase *CS : Calls)
Expand Down
2 changes: 1 addition & 1 deletion llvm/test/Transforms/GlobalOpt/resolve-fmv-ifunc.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,7 @@ resolver_entry:
define i32 @caller4() #8 {
; CHECK-LABEL: define i32 @caller4(
; CHECK-SAME: ) local_unnamed_addr #[[ATTR7:[0-9]+]] {
; CHECK: [[CALL:%.*]] = tail call i32 @test_non_fmv_caller._Maes()
; CHECK: [[CALL:%.*]] = tail call i32 @test_non_fmv_caller()
;
entry:
%call = tail call i32 @test_non_fmv_caller()
Expand Down
Loading