Skip to content

[CIR][NFC] Change GetMemberOp index type #1811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 15, 2025
+2 −15
Merged

[CIR][NFC] Change GetMemberOp index type #1811

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 2 additions & 15 deletions clang/include/clang/CIR/Dialect/IR/CIROps.td
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2962,29 +2962,16 @@ def CIR_GetMemberOp : CIR_Op<"get_member"> {
let arguments = (ins
Arg<CIR_PointerType, "the address to load from", [MemRead]>:$addr,
StrAttr:$name,
IndexAttr:$index_attr);
I64Attr:$index);

let results = (outs Res<CIR_PointerType, "">:$result);

let assemblyFormat = [{
$addr `[` $index_attr `]` attr-dict
$addr `[` $index `]` attr-dict
`:` qualified(type($addr)) `->` qualified(type($result))
}];

let builders = [
OpBuilder<(ins "mlir::Type":$type,
"mlir::Value":$value,
"llvm::StringRef":$name,
"unsigned":$index),
[{
mlir::APInt fieldIdx(64, index);
build($_builder, $_state, type, value, name, fieldIdx);
}]>
];

let extraClassDeclaration = [{
/// Return the index of the record member being accessed.
uint64_t getIndex() { return getIndexAttr().getZExtValue(); }

/// Return the record type pointed by the base pointer.
cir::PointerType getAddrTy() { return getAddr().getType(); }
Expand Down
Loading