Consolidate sync actions in route handlers - #240
Open
cmelone wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR consolidates duplicated logic in GitHub route handlers by extracting common sync, delete, and pipeline context operations into shared helper functions. The RepoConfig class is also updated to compute fullname automatically.
Changes:
- Extracted
_sync_refs,_delete_ref,_get_dest_context,_get_pr_target_ref, and_get_pr_pipeline_contextas shared helpers to eliminate duplicated code across push and pull request event handlers. - Simplified
sync_prsignature by removing thesrc_repo_privateparameter (now derived from thepull_requestdict directly). - Changed
RepoConfig.fullnameto be auto-computed fromdest_organddest_nameinstead of being passed as a separate parameter.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/hubcast/web/github/routes.py |
Route handlers refactored to use new helper functions, removing significant code duplication |
src/hubcast/repos/config.py |
RepoConfig.fullname now auto-computed from dest_org/dest_name |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
2 tasks
cmelone
added a commit
to cmelone/hubcast
that referenced
this pull request
Mar 5, 2026
Hubcast config settings for repos should only be fetched from the default branch of the base repository. Previously, we were getting the config from the head repo, which would lead to potential confusion for users submitting PRs via forks. This ensures that there is one source of settings for each repository. I pulled this out of llnl#240 to make for a faster review.
alecbcs
pushed a commit
that referenced
this pull request
Mar 6, 2026
Hubcast config settings for repos should only be fetched from the default branch of the base repository. Previously, we were getting the config from the head repo, which would lead to potential confusion for users submitting PRs via forks. This ensures that there is one source of settings for each repository. I pulled this out of #240 to make for a faster review.
cmelone
force-pushed
the
add/consolidate-syncs
branch
5 times, most recently
from
March 11, 2026 21:15
9e8e2e5 to
c9ac693
Compare
cmelone
marked this pull request as ready for review
March 11, 2026 21:16
cmelone
force-pushed
the
add/consolidate-syncs
branch
from
March 11, 2026 23:01
c9ac693 to
a26cc77
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cmelone
force-pushed
the
add/consolidate-syncs
branch
from
March 25, 2026 00:16
dc3e0ce to
9f5ff47
Compare
cmelone
force-pushed
the
add/consolidate-syncs
branch
4 times, most recently
from
April 10, 2026 23:00
e3e100d to
525b576
Compare
There was a lot of duplicated code/logic in the route handlers, especially for the sync/delete ref actions. I was a bit aggressive with the consolidation, so let me know if you'd like to keep something expanded. address review add guard when a ref to be deleted does not exist unconsolidate _get_pr_pipeline_context and _get_dest_context style
cmelone
force-pushed
the
add/consolidate-syncs
branch
from
April 13, 2026 20:37
525b576 to
b71c69c
Compare
alecbcs
pushed a commit
that referenced
this pull request
Jul 22, 2026
This PR adds support for sending messages back to users if their intended action fails due to insufficient permissions. Any requests to Gitlab can fail if the user account we're impersonating is not set up properly. 1. with the `guest` role, the user can't read the repo 2. with the `reporter` role, the user can't write to the repo 3. with the `developer` role, the user can't read or write repo webhooks If we hit (1) or (2) during a sync action, Hubcast will set a status to the commit notifying the user of the issue and pointing to the permissions requirements in the docs. In the case of deletions, we have no way to set a GitHub check status so the event will be logged and available to admins. The way we go about catching exceptions is ugly, but modularization is limited by the fact that most cases need unique handling, other than actions like syncing/deleting refs (which should really be consolidated like in #240). Please let me know if you have ideas about making this all more readable. Handling webhook setting: - we now check if hubcast configuration files have been added/edited/deleted in the push event to the default branch - if the webhook set fails, we set a check with an error message saying that a maintainer needs to push an update to the config or an empty commit with the message `[hubcast config`] --- TODO - [x] once this is in a polished state, add tests - [x] we'll need to cut a repligit release to handle the rejected push exceptions closes #355 --------- Signed-off-by: Caetano Melone <melone1@llnl.gov>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a lot of duplicated code/logic in the route handlers, especially for the sync/delete ref actions. I was a bit aggressive with the consolidation, so let me know if you'd like to keep something expanded.