Skip to content

Conversation

@AdityaKrSingh26
Copy link
Contributor

@AdityaKrSingh26 AdityaKrSingh26 commented Jan 7, 2025

Fix : #1551

Earlier the images were set as background image to the whole canvas as a result they were not resizable.
In this fix i have made the images as a sperate globe which is resizable.

After fix:

sugar.mp4

@AdityaKrSingh26
Copy link
Contributor Author

Hey @llaske please have a look at this

@llaske
Copy link
Owner

llaske commented Jan 12, 2025

It's nice but it broke the way of using the activity.
When the image icon is clicked it suppose to add a new page in the comic.
Now it's no longer possible to add page.

@AdityaKrSingh26
Copy link
Contributor Author

AdityaKrSingh26 commented Jan 13, 2025

It's nice but it broke the way of using the activity. When the image icon is clicked it suppose to add a new page in the comic. Now it's no longer possible to add page.

okay ..... i was not aware of that feature.
We can do 3 things:

  1. either add a button to add new page
  2. or add a new page when next page button is clicked if the current page is the last page.
  3. or we can also do one thing that on one page we can add only one image and when new image a new page is created.

@llaske
Copy link
Owner

llaske commented Jan 14, 2025

The better option is the third.

@AdityaKrSingh26
Copy link
Contributor Author

The better option is the third.

Okay i will work on this
Just one thing i would like to make sure is that going with option 3 we will have only one image per page.

@llaske
Copy link
Owner

llaske commented Jan 15, 2025

with option 3 we will have only one image per page.

yes, that's right

@AdityaKrSingh26
Copy link
Contributor Author

AdityaKrSingh26 commented Mar 2, 2025

hey @llaske please have a look at my latest commit, made the changes you mentioned. I have added the code for resizing the image and when new image is added a new page is created

Preview:

sugar.mp4

@llaske
Copy link
Owner

llaske commented Mar 12, 2025

Good job.
But when opening an existing Fototoon activity with the new version, it shrink images inside.

image

become:

image

@AdityaKrSingh26
Copy link
Contributor Author

My older commit was not keeping the aspect ratio of image when it was first loaded. I have updated it so that the original aspect ratio of image is respected.

@llaske please have a look at my latest commit.

@llaske
Copy link
Owner

llaske commented Mar 30, 2025

I've tested your latest PR, there is a memory leak issue.
I've created a three redimensioned images project with some globes.
After navigating several times from a page to another, images are not displayed or displayed at the wrong place.
It's not happens on the original activity.

Capture.video.du.2025-03-30.11-48-53.webm

@AdityaKrSingh26
Copy link
Contributor Author

Got it ..... I'll try to fix this and update the pr

@AdityaKrSingh26
Copy link
Contributor Author

Hey @llaske please have a look at my latest commit. I have added :

  • A cleanup method to Clean up previous resources first and ensure when new comic box is loaded previous one is cleaned.
  • Created a completion handler to process any pending changes.
Recording.2025-04-05.002129.mp4

@llaske
Copy link
Owner

llaske commented Apr 5, 2025

Hmmm it fix the issue but it's much less fluid, the user has to wait 1 second to switch between pages 😞

@AdityaKrSingh26
Copy link
Contributor Author

Hmmm it fix the issue but it's much less fluid, the user has to wait 1 second to switch between pages 😞

I am having difficulty understanding why this is happening ........... but I'll give it a try

@AdityaKrSingh26 AdityaKrSingh26 marked this pull request as draft June 2, 2025 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants