fix(linter): tighten Zig doc comment detection#8
Open
xen0n wants to merge 1 commit intoliyi-run:mainfrom
Open
Conversation
Only the immediately preceding Zig comment should count as a doc comment for a declaration. Add focused tests for functions and struct declarations covering both documented and non-documented cases. Root cause: the previous Zig detector walked backward across multiple comment siblings, so a declaration could incorrectly inherit an earlier `///` doc block even when a regular `//` comment intervened. Original prompt: > Ah please rebase and salvage useful bits then. If nothing is useful that's > also OK. > okay please push and PR then > Where's your AIGC disclosure? Check the commit convention in AGENTS.md and > fix the PR. AI-assisted-by: GPT-5.4 (OpenClaw)
bd845ec to
b0ae453
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
///block across an intervening regular//commentRoot cause
///doc block even when a regular//comment intervenedTesting