Skip to content

worker: Add HF_TOKEN to runner container on creation #3693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

hjpotter92
Copy link
Member

Also provide clear hostname inside container when multiple containers are running on same host.

Also provide clear hostname inside container when multiple containers
are running on same host.
@hjpotter92 hjpotter92 requested review from leszko and emranemran July 31, 2025 10:55
@hjpotter92 hjpotter92 self-assigned this Jul 31, 2025
@github-actions github-actions bot added go Pull requests that update Go code AI Issues and PR related to the AI-video branch. labels Jul 31, 2025
Copy link

codecov bot commented Jul 31, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 31.92539%. Comparing base (e7f0ee1) to head (7fc918b).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
ai/worker/docker.go 50.00000% 2 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##              master       #3693         +/-   ##
===================================================
+ Coverage   31.92386%   31.92539%   +0.00153%     
===================================================
  Files            156         156                 
  Lines          47441       47445          +4     
===================================================
+ Hits           15145       15147          +2     
- Misses         31401       31402          +1     
- Partials         895         896          +1     
Files with missing lines Coverage Δ
ai/worker/docker.go 72.62774% <50.00000%> (-0.35020%) ⬇️

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7f0ee1...7fc918b. Read the comment docs.

Files with missing lines Coverage Δ
ai/worker/docker.go 72.62774% <50.00000%> (-0.35020%) ⬇️

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@leszko leszko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @hjpotter92 Could you add in the description why we need to pass HF_TOKEN into the runner? Why does runner need to connect to HuggingFace?

Copy link
Contributor

@leszko leszko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added one suggestion

@hjpotter92 hjpotter92 requested a review from varshith15 August 1, 2025 05:04
@hjpotter92
Copy link
Member Author

Thanks for the PR @hjpotter92 Could you add in the description why we need to pass HF_TOKEN into the runner? Why does runner need to connect to HuggingFace?

There's a possibility that this PR is not needed. @varshith15 mentioned getting rate limited. I'll add him as a reviewer as well and hold off on activity on this PR.

@varshith15
Copy link
Member

so the main issue was that we are loading controlnets and unets in pytorch to detect the model type -- each model load takes about 3-4 sec and loading all controlnets adds upto the 15 sec josh noticed. this also adds to the vram as the pytorch models are not being unloaded after model type detection. ideally we shouldn't be loading any pytorch models and detect the model type from the model config instead (working on that).

so we should pause the PR for now, can revisit if we still face the issue after i push the above fix @hjpotter92

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AI Issues and PR related to the AI-video branch. go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants