Skip to content

Conversation

SamborGornicz
Copy link
Collaborator

Added support for retrieving theme values through the getTheme method and the change_theme event:

• Each widget now includes a getTheme method, which will return the current parent theme value based on the initial theme specified in the widget URL via the ?theme=dark|light query parameter and on data provided from change_theme.
• Added TypeScript definitions for the change_theme event, which is triggered whenever the theme changes in the Agent App.

Copy link

changeset-bot bot commented Jan 24, 2025

⚠️ No Changeset found

Latest commit: 00333a2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Collaborator

@arturfracala arturfracala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looks good 👍🏿

"dependencies": {
"@babel/runtime": "^7.2.0",
"@livechat/mitt": "0.1.2",
"@livechat/postmessage": "^0.3.2",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these libraries not being used?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, they are not used in the agent-app-sdk, but they are present in the widget-sdk-core. I assume they might have been used in the past, or perhaps the package.json file was simply copied from widget-sdk-core.

@SamborGornicz SamborGornicz merged commit 976fc36 into master Jan 29, 2025
3 checks passed
@SamborGornicz SamborGornicz deleted the feature/change-theme branch January 29, 2025 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants