Open
Conversation
Collaborator
|
Tests are failing. Moreover you've missed to cover this with a new test, which I would like to have :) |
Contributor
Author
|
I'll see if I have time latter, curious as you don't even have strict types turned on 🤷 |
Collaborator
|
The builds are broken due to static analisys tools.
At first glance, it seems we don't have. It would be a great chance to improve all the tests for this kind of scenario if you will. Don't know if it's tough tho. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When testing I had an odd error that meant I would get "no scenarios" in the output - while there maybe other ways around it I created a new merge parameter to output the "clean" file so that I could name them
--out=my_output_file_{clean_filename}_p{p}_n{n}created so this would clearly indicate which scenario was the problem. The problem was actually that when I calledbin/behat --tags=@tag --list-scenarios | vendor/liuggio/fastest/fastest "bin/behat {}"this missed the tags in each separate call which then used the default suite tags frombehat.ymland therefore couldn't find the scenario.Also found it confusing to have a merge tag with no label so I suggest that is updated inline with the new merge tag.