Skip to content

New merge parameters#198

Open
barryswaisland-eagleeye wants to merge 1 commit intoliuggio:masterfrom
barryswaisland-eagleeye:useful_parameters
Open

New merge parameters#198
barryswaisland-eagleeye wants to merge 1 commit intoliuggio:masterfrom
barryswaisland-eagleeye:useful_parameters

Conversation

@barryswaisland-eagleeye
Copy link
Copy Markdown
Contributor

When testing I had an odd error that meant I would get "no scenarios" in the output - while there maybe other ways around it I created a new merge parameter to output the "clean" file so that I could name them --out=my_output_file_{clean_filename}_p{p}_n{n} created so this would clearly indicate which scenario was the problem. The problem was actually that when I called bin/behat --tags=@tag --list-scenarios | vendor/liuggio/fastest/fastest "bin/behat {}" this missed the tags in each separate call which then used the default suite tags from behat.yml and therefore couldn't find the scenario.

Also found it confusing to have a merge tag with no label so I suggest that is updated inline with the new merge tag.

@DonCallisto
Copy link
Copy Markdown
Collaborator

Tests are failing. Moreover you've missed to cover this with a new test, which I would like to have :)

@barryswaisland-eagleeye
Copy link
Copy Markdown
Contributor Author

I'll see if I have time latter, curious as you don't even have strict types turned on 🤷
Just to be sure though, I don't see any tests covering these merge parameters as it is?

@DonCallisto
Copy link
Copy Markdown
Collaborator

The builds are broken due to static analisys tools.

Just to be sure though, I don't see any tests covering these merge parameters as it is?

At first glance, it seems we don't have. It would be a great chance to improve all the tests for this kind of scenario if you will. Don't know if it's tough tho.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants