-
-
Notifications
You must be signed in to change notification settings - Fork 101
docs: add migration guide #704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
adhtruong
wants to merge
8
commits into
main
Choose a base branch
from
add-migration-guide
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
07042de
docs: add migration guide
adhtruong b780739
Merge branch 'main' into add-migration-guide
adhtruong de39a76
docs: align header lengths
adhtruong 999ba01
Discard changes to polyfactory/utils/model_coverage.py
adhtruong 9812cde
Merge branch 'main' into add-migration-guide
adhtruong 332d302
Merge branch 'main' into add-migration-guide
adhtruong 67b1eaa
Merge branch 'main' into add-migration-guide
adhtruong 22dc838
docs: amend typos
adhtruong File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,70 @@ | ||
Migration Guide | ||
============== | ||
|
||
.. note:: | ||
This guide is for an unrelease version of polyfactory. | ||
|
||
For v2 to v3 migration, this is largely deprecation internal parameters and updating defaults to be more aligned with common use cases. | ||
|
||
SQLAlchemyFactory Default Changes | ||
---------------------------------------- | ||
|
||
In the latest version, we've made changes to the default behavior of SQLAlchemyFactory to better align with common use cases. Here are the key changes and how to migrate: | ||
|
||
Default Relationship Behavior | ||
~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
|
||
**Before:** | ||
|
||
- ``__set_relationships__`` defaulted to ``False`` | ||
- Relationships were not automatically populated unless explicitly enabled | ||
|
||
**After:** | ||
|
||
- ``__set_relationships__`` now defaults to ``True`` | ||
- Relationships are automatically populated by default | ||
|
||
To maintain the previous behavior, explicitly set ``__set_relationships__ = False`` in your factory: | ||
|
||
Default Association Proxy Behavior | ||
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
|
||
**Before:** | ||
|
||
- ``__set_association_proxy__`` defaulted to ``False`` | ||
- Association proxies were not automatically populated unless explicitly enabled | ||
|
||
**After:** | ||
|
||
- ``__set_association_proxy__`` now defaults to ``True`` | ||
- Association proxies are automatically populated by default | ||
|
||
To maintain the previous behavior, explicitly set ``__set_association_proxy__ = False`` in your factory: | ||
|
||
Model Validation Behavior | ||
--------------------------------------- | ||
|
||
**Before:** | ||
|
||
- ``__check_model__`` defaulted to ``False`` | ||
- Model structure validation was disabled by default | ||
|
||
**After:** | ||
|
||
- ``__check_model__`` now defaults to ``True`` | ||
- Model structure validation is enabled by default | ||
- This helps catch potential issues with model definitions early | ||
|
||
To maintain the previous behavior, explicitly set ``__check_model__ = False`` in your factory: | ||
|
||
Fixture Field Removal | ||
--------------------------------------- | ||
adhtruong marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
The ``polyfactory.fields.Fixture`` field has been removed in v3. This was a legacy field that was used to define factory behavior through a separate ``pytest`` fixture. | ||
|
||
Instead, all factories can be used directly as `factories as fields <https://polyfactory.litestar.dev/latest/usage/fields.html#factories-as-fields>`_. For batch usage, this can be combined with ``Use`` or similar. | ||
|
||
Internal Parameter Changes | ||
--------------------------------------- | ||
|
||
Several internal parameters have been removed or changed in v3 to simplify ``FieldMeta`` and typing utils to be deterministic. Usage of ``random.Random`` parameters should be removed as per warning emitted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.