-
-
Notifications
You must be signed in to change notification settings - Fork 490
feat: deprecate contrib.opentelemetry
#4477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4477 +/- ##
==========================================
- Coverage 97.83% 97.24% -0.60%
==========================================
Files 296 301 +5
Lines 15295 15404 +109
Branches 1713 1717 +4
==========================================
+ Hits 14964 14979 +15
- Misses 189 285 +96
+ Partials 142 140 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hi — just a quick note. This PR (#4477) appears to be failing for the same reason, so once the intersphinx URL is updated, the docs build here should pass as well. Thanks as always for your help and explanations — really appreciate it. |
Just a heads up. We've temporarily reverted the domain swap. I'll bring it back in once we have a way to preserves the old links. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For a deprecation that's scheduled for a removal, this should be pointed at the v2 branch :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some followup changes for this in the main branch that i was making in a followup PR. Can I open another PR once this merges to get this into the v2 branch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess you could merged these into main and then cherry-pick them into v2
|
Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/4477 |
|
There's a follow-up PR #4483 that should merge after this one. It should instrument the components that are not instrumented by the ASGI Open Telemetry integration. |
Silence a few configurations and deprecate the
litestar.contrib.opentelemetrymodule in favor oflitestar.plugins.opentelemetry, updating the relevant imports and adding tests for the deprecation warnings.