Skip to content

Conversation

@cofin
Copy link
Member

@cofin cofin commented Nov 17, 2025

Silence a few configurations and deprecate the litestar.contrib.opentelemetry module in favor of litestar.plugins.opentelemetry, updating the relevant imports and adding tests for the deprecation warnings.

@codecov
Copy link

codecov bot commented Nov 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.24%. Comparing base (bcea856) to head (44a0d90).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4477      +/-   ##
==========================================
- Coverage   97.83%   97.24%   -0.60%     
==========================================
  Files         296      301       +5     
  Lines       15295    15404     +109     
  Branches     1713     1717       +4     
==========================================
+ Hits        14964    14979      +15     
- Misses        189      285      +96     
+ Partials      142      140       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sion908
Copy link

sion908 commented Nov 17, 2025

Hi — just a quick note.
I ran into the same documentation build error on my side, and after digging into it I found that the issue came from the Advanced Alchemy intersphinx mapping still pointing to the old domain. I opened an issue (#4479) and submitted a fix in PR #4480.

This PR (#4477) appears to be failing for the same reason, so once the intersphinx URL is updated, the docs build here should pass as well.

Thanks as always for your help and explanations — really appreciate it.

@cofin
Copy link
Member Author

cofin commented Nov 17, 2025

Hi — just a quick note. I ran into the same documentation build error on my side, and after digging into it I found that the issue came from the Advanced Alchemy intersphinx mapping still pointing to the old domain. I opened an issue (#4479) and submitted a fix in PR #4480.

This PR (#4477) appears to be failing for the same reason, so once the intersphinx URL is updated, the docs build here should pass as well.

Thanks as always for your help and explanations — really appreciate it.

Just a heads up. We've temporarily reverted the domain swap. I'll bring it back in once we have a way to preserves the old links.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For a deprecation that's scheduled for a removal, this should be pointed at the v2 branch :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some followup changes for this in the main branch that i was making in a followup PR. Can I open another PR once this merges to get this into the v2 branch?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you could merged these into main and then cherry-pick them into v2

@github-actions github-actions bot added the area/docs This PR involves changes to the documentation label Nov 18, 2025
@github-actions
Copy link

Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/4477

@cofin
Copy link
Member Author

cofin commented Nov 19, 2025

There's a follow-up PR #4483 that should merge after this one. It should instrument the components that are not instrumented by the ASGI Open Telemetry integration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/docs This PR involves changes to the documentation pr/internal size: medium type/feat

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants