Skip to content

Conversation

@cstarkers
Copy link
Contributor

Description

Allow a single query parameter to be aliased to multiple Python parameters, even when one of the Python parameters is a list.

Previously, if a query paramater was remapped to multiple different Python paramenters by using Parameter(query="alias") and one of the Python parameters was a list, a validation error was raised. This was inconsisent with how non-list query parameters worked.

Fixes #4242

@cstarkers cstarkers requested review from a team as code owners November 12, 2025 10:35
@github-actions github-actions bot added area/kwargs area/private-api This PR involves changes to the privatized API size: small type/bug pr/external Triage Required 🏥 This requires triage labels Nov 12, 2025
@codecov
Copy link

codecov bot commented Nov 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.83%. Comparing base (9bcae1e) to head (518da05).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4469   +/-   ##
=======================================
  Coverage   97.83%   97.83%           
=======================================
  Files         296      296           
  Lines       15295    15311   +16     
  Branches     1713     1713           
=======================================
+ Hits        14964    14980   +16     
  Misses        189      189           
  Partials      142      142           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cstarkers cstarkers marked this pull request as draft November 12, 2025 10:41
@github-actions
Copy link

Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/4469

@cstarkers cstarkers changed the title fix: duplicate query parameters where one of the paramaters is a list fix: duplicate query parameters fail validation if one of the paramaters is a list Nov 12, 2025
@cstarkers cstarkers marked this pull request as ready for review November 12, 2025 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/kwargs area/private-api This PR involves changes to the privatized API pr/external size: small Triage Required 🏥 This requires triage type/bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: multiple parameters with duplicate query works inconsistently

1 participant