Fix unsound multiplication in Sign domain#361
Merged
Conversation
lucaneg
approved these changes
Apr 15, 2026
lucaneg
added
⁉ priority:p2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When evaluating a binary expression with a MultiplicationOperator, if both operands are TOP, the implementation of the Sign Domain incorrectly returns +. However, since TOP represents any value (+, −, or 0), TOP × TOP should return TOP.
Similarly, if only one operand is TOP, the implementation retruns −, but TOP × + ≠ −.
Fixed bugs
No open issue related to this bug.
Implemented features
Added an isTop() guard: if either operand is TOP, the operation now returns TOP.
Further content
None.