feat: format (pretty-print) STAC files TDE-759#172
Draft
paulfouquet wants to merge 5 commits intomasterfrom
Draft
feat: format (pretty-print) STAC files TDE-759#172paulfouquet wants to merge 5 commits intomasterfrom
paulfouquet wants to merge 5 commits intomasterfrom
Conversation
l0b0
reviewed
Nov 2, 2023
| apiVersion: argoproj.io/v1alpha1 | ||
| kind: WorkflowTemplate | ||
| metadata: | ||
| name: tpl-at-format |
Contributor
There was a problem hiding this comment.
What's "at" in this? "Argo task"? Would including "stac" somewhere be clearer, such as "tpl-at-format-stac"?
Also, other templates have names like "create-collection". Is "tpl-at-" redundant?
| - name: source | ||
| description: Path to format files from | ||
| - name: target | ||
| description: (Optional) Target directory (testing) |
Contributor
There was a problem hiding this comment.
If this is empty, does it format files in-place? As a newbie, that might be useful clarification. If we are relying on third party functionality, it might be OK to just link to the (appropriate version of the) reference somewhere.
| default: "" | ||
| - name: fix-content-type | ||
| description: (Optional) Set the content-type to S3 object | ||
| default: "" |
Contributor
There was a problem hiding this comment.
What are valid values here? Are these MIME types, as used by the HTTP Content-Type header? What happens if this is empty?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add a
WorkflowTemplateto format files that callslinz/argo-taskspretty-printcommand. This template is used inimagery-standardisingworkflow.Intention
Some of the STAC files (
Item) are not pretty printed. Having aWorkflowTemplateallows to format files inside a workflow for newly created files. It can also be ran as a one-off job for existing files.Checklist
If not applicable, provide explanation of why.