Skip to content

Add support for Google's Favicon API as a fallback option #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 24, 2025

Conversation

diam0ndkiller
Copy link
Contributor

As described in my issue (#349) there is a problem when trying to download Favicons for pages with redirects. Google hosts an API to reliably get the Favicon for any page by just passing in the URL.

I would suggest adding support for this API to use when fetching Favicons for a Webapp. Even though Google as a company is not quite Open-Source friendly, their API has no apparent underlying license and is used by many projects.

I believe the added reliability is worth the ideological compromise.

related to #340 and my own #349

@mtwebster mtwebster merged commit a636d6e into linuxmint:master Jul 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants