Skip to content

Added support for config file #412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Added support for config file #412

wants to merge 4 commits into from

Conversation

jay763190097
Copy link

No description provided.

@RandallPittmanOrSt
Copy link

Comments from a passerby who doesn't know much about the Timeshift source:

  1. There should be a description of what problem this PR is addressing.
  2. .vscode folder does not belong and should be removed. Also the changes to .gitignore shouldn't be merged.
  3. Files changed seem to show that the author is making other (probably benign, but I don't know) changes that aren't related to the PR title.

1 and 3 are big red flags to me.

@jay763190097
Copy link
Author

Hi @RandallPittmanOrSt,

  1. I'll add a description and its related issue number.
  2. I'll remove .vscode and changes in .gitignore
  3. That's because I met an issue related pkexec, and I fixed it via this approach.

@jay763190097
Copy link
Author

jay763190097 commented Jun 18, 2025 •
edited
Loading

@RandallPittmanOrSt This PR is trying to implement the requirement for #348 #357 #198.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jay763190097 @RandallPittmanOrSt