sound-applet: Fix mute/unmute toggle when clicking volume icon (#13053) #13054
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d using the icon.
|
I’ve noticed that while this fix works in most cases, there are rare situations where clicking the sound icon doesn’t unmute as expected. I’m still trying to identify the exact trigger, but wanted to flag it here so reviewers are aware |
mintFix2.trimmed.mp4 |
|
Hi @mtwebster , just wondering if this fix is valid and if there’s any feedback I should take into account. I’d really like to understand if I’m approaching this the right way, so I can improve my future contributions. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where clicking the speaker icon in the Cinnamon sound applet popup would only mute audio but not restore/unmute it.
Before: Clicking the icon muted sound, but subsequent clicks had no effect.
After: Clicking the icon now correctly toggles between mute and unmute.
Steps to test
Build and restart Cinnamon (Alt+F2 → r → Enter).
Open the sound applet from the panel.
Click the speaker icon next to the volume slider:
First click → mutes audio.
Second click → unmutes audio.
Related issue
Fixes #13053