Add generated getters/setters #2956
Closed
+2,108
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 6, 2025 11:38
This adds the ability to automatically generate accessor functions (setter/getter functions) by parsing structs definitions in header files. Two files are generated: [accessors.c, accessors.h]. Signed-off-by: Martin Belanger <[email protected]>
Before this fix, #includes and forward declarations were inserted in the generated outputs on a first-come-first-serve basis. In other words, #include statements and forward struct declarations would get scattered thoughout the output instead of appearing at the top of the files as they should. This patch ensures that all #includes and forward declarations appear at the top of the file where it is customary to find them. Signed-off-by: Martin Belanger <[email protected]>
|
@igaw - If it's OK, I would like to submit a fresh pull request for this. I want to split the PR in 2. There's a few meson.build clean ups I want to submit in a first PR. Then I will submit a second PR for the accessor generator. |
Collaborator
Author
|
I'll close this one, and you can create your own then :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nvme-experiments/libnvme#54
nvme-experiments/libnvme#108