nvme: enforce ns granularity on ns create #2722
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igaw
force-pushed
the
create-ns-align
branch
2 times, most recently
from
aba43b9 to
8e5b686
Compare
Collaborator
Author
|
Only compile tested and don't have any device at hand for testing. If anyone else could give it a go, I would highly appreciate it. Thanks. |
Contributor
|
@igaw I would replace this phrase: with the following: "[...] in standard SI units (aligned on 1Mib boundaries, |
When the device supports the namespace granularity feature, update the alignment requirements accordingly. Because this is likely to change the capacity of the namespace also issue a info what is going to happen. Signed-off-by: Daniel Wagner <[email protected]>
igaw
force-pushed
the
create-ns-align
branch
from
8e5b686 to
89241e0
Compare
Contributor
|
Looks ok to me now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the device supports the namespace granularity feature, update the alignment requirements accordingly. Because this is likely to change the capacity of the namespace also issue a info what is going to happen.
Fixes: #2721