qcs8300: update dynamic modules for QCS8300 RIDE platform #9
Conversation
|
DSP FW Release for DSP.AT.1.0.1-00125.5-LEMANS-1 |
There was a problem hiding this comment.
-
Please fix your git config to use your actual name in git commit metadata and in the SoB tags, then refresh your commits.
vkasinatis not your name. -
WHENCE file should contain both versions as both of them are present in the repo. Config file should list the version that is going to be installed. Include the link to archive, if possible
-
Use
git log, then rewrite your subject and your commit message to follow -
Squash WHENCE and firmware addition commits.
-
Installed files should reflect the files provided by the linux-firmware. I don't see a corresponding change being posted there.
|
Why are you resubmitting commits that are already a part of the tree? |
Fixing this. |
|
Below is the link for the DSP FW Update request. |
There was a problem hiding this comment.
- git metadata wasn't updated:
From: vkasinat <[email protected]>
Also carrying over from the previous review:
- Use git log, then rewrite your subject and your commit message to follow
|
Closing this PR. There is a fix that is coming up and would add that in the next PR. |
|
I've reopened this PR and will convert it to the draft. Please push new data to the same PR. |
vkasinat
force-pushed
the
qcs8300
branch
2 times, most recently
from
17365b4 to
8d41118
Compare
|
https://git.codelinaro.org/clo/linux-kernel/linux-firmware/-/tree/dsp-fw-qcs8300-dsp125?ref_type=heads is the link to the Firmware |
And your commit subject & commit message for the linux-firmware are still beyond the standards. |
| Install: qcs8300/Qualcomm/QCS8300-RIDE adsp adsp-DSP.AT.1.0.1-00096-LEMANS-1 | ||
| Install: qcs8300/Qualcomm/QCS8300-RIDE cdsp cdsp-DSP.AT.1.0.1-00096-LEMANS-1 | ||
| Install: qcs8300/Qualcomm/QCS8300-RIDE gdsp0 gdsp0-DSP.AT.1.0.1-00096-LEMANS-1 | ||
| Install: qcs8300/Qualcomm/QCS8300-RIDE adsp adsp-DSP.AT.1.0.1-00125.5-LEMANS-1 |
There was a problem hiding this comment.
Squash into the previous commit, please.
There was a problem hiding this comment.
Done. Please review.
vkasinat
force-pushed
the
qcs8300
branch
3 times, most recently
from
6754b76 to
43bdc69
Compare
vkasinat
changed the title
Update dynamic modules for adsp, cdsp and gpdsp for QCS8300 RIDE platform. Signed-off-by: Venkata Kota <[email protected]>
DSP Dynamic Modules for DSP.AT.1.0.1-00125.5-LEMANS-1 on QCS8300