This repository was archived by the owner on Mar 25, 2024. It is now read-only.
add NME_SC method for clustering #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jeronymous
reviewed
Mar 30, 2023
Member
Jeronymous
left a comment
Jeronymous
left a comment
There was a problem hiding this comment.
Some comments after a first quick reading here.
I noticed that the function cluster_AHC does not have any option max_speakers.
Is it normal? Would it make sense to add such an option there?
| def NME_SpectralClustering( | ||
| A, num_clusters=None, max_num_clusters=10, pbest=0, pmin=3, pmax=20 | ||
| ): | ||
| print(num_clusters,max_num_clusters) |
Member
There was a problem hiding this comment.
No print without any string to explain.
This one looks like a debug print. remove it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add auto-tuning NME_spectral clustering