docs: create a Lingo.dev CLI integration guide for angular #1337 #1348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
praveen-nagula
changed the title
Contributor
|
Hi 👋 Thanks for the submission. I've assigned myself to review the PR in more depth and will get to it shortly. At first glance, the scope of the guide may be too big. Ideally, it'd match the structure/scope of existing guides. Thanks. 😄 |
Reduced guide from 1,037 to 234 lines to align with existing framework guides. - Simplified to 6 core steps - Removed extensive demo app code - Focused on essential ngx-translate integration - Kept TypeScript alternative as bonus section Addresses reviewer feedback on PR scope.
Author
|
Hi @davidturnbull , Thanks for the feedback, I have made the changes to condense the content. Please review Thanks 😊 |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds an integration guide for using Lingo.dev CLI with Angular applications, specifically focusing on ngx-translate integration for runtime internationalization.
Key Changes:
- Complete step-by-step tutorial for integrating Lingo.dev CLI with Angular 17+ (standalone components) and Angular 16 or earlier (NgModule)
- Configuration examples for ngx-translate with both JSON and TypeScript translation files
- Working language switcher implementation
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…n files directly. Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a comprehensive integration guide for using Lingo.dev CLI with Angular applications, addressing issue #1337.
What's Included
Framework-Specific Features
Testing
The guide has been cross-referenced with:
Ready for live testing by maintainers following the guide steps.
Workflow
Following the documentation contribution workflow from CONTRIBUTING.md:
Closes #1337