-
Notifications
You must be signed in to change notification settings - Fork 667
feat/added Sindhi language support (sd) #1310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Shivangbijalwan
wants to merge
4
commits into
lingodotdev:main
Choose a base branch
from
Shivangbijalwan:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
50393ee
feat/added Sindhi language support (sd)
Shivangbijalwan f4db97e
Merge branch 'main' into main
Shivangbijalwan 565c87d
Add 'mr' to the language list in i18n.json
Shivangbijalwan 9ae8a4f
Merge branch 'lingodotdev:main' into main
Shivangbijalwan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -19,7 +19,9 @@ | |
| "bn", | ||
| "fa", | ||
| "pl", | ||
| "tr" | ||
| "tr", | ||
| "sd", | ||
| "mr" | ||
| ] | ||
| }, | ||
| "buckets": { | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR adds Marathi ("mr") language support in addition to Sindhi ("sd"), but the PR title and description only mention Sindhi language support. This creates confusion about the scope of changes. Either the PR description should be updated to mention both languages, or "mr" should be removed if it wasn't intended to be included in this PR.