This repository was archived by the owner on Mar 31, 2021. It is now read-only.
Debian 9 support #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbaechler
reviewed
Sep 1, 2017
Contributor
mbaechler
left a comment
mbaechler
left a comment
There was a problem hiding this comment.
Thank you very much for this PR.
I have small comments on it but it's great overall.
Dockerfile
Outdated
| RUN cd obm/java/sync && \ | ||
| mvn dependency:go-offline || true && \ | ||
| mvn package -T1C | ||
| mvn package -DskipTests -T1C |
Contributor
There was a problem hiding this comment.
I think it's not the intent of this changeset.
java/tomcat/debian/obm-tomcat.init
Outdated
|
|
||
| if [ -z "$JAVA_HOME" ]; then | ||
| JAVA_HOME="/usr/lib/jvm/java-7-openjdk-"`dpkg --print-architecture` | ||
| JAVA_HOME="usr" |
Contributor
There was a problem hiding this comment.
java_home can't really be defined as usr because it expect a specific directory layout.
It has to be /usr/lib/jvm/something
Author
|
Ok thanks
Please do your comments. Will do changes next weekend.
Jérémy Carnus
________________________________
De: Matthieu Baechler <[email protected]>
Envoyé: 1 sept. 2017 03:09
À: linagora/OBM
Cc: Jérémy Carnus; Author
Objet: Re: [linagora/OBM] Debian 9 support (#1)
@mbaechler commented on this pull request.
Thank you very much for this PR.
I have small comments on it but it's great overall.
________________________________
In Dockerfile:
@@ -35,7 +35,7 @@ ADD . obm
## BUILD OBM PACKAGES
RUN cd obm/java/sync && \
mvn dependency:go-offline || true && \
- mvn package -T1C
+ mvn package -DskipTests -T1C
I think it's not the intent of this changeset.
________________________________
In java/tomcat/debian/obm-tomcat.init:
@@ -36,7 +36,7 @@ if [ -r /etc/default/rcS ]; then
fi
if [ -z "$JAVA_HOME" ]; then
- JAVA_HOME="/usr/lib/jvm/java-7-openjdk-"`dpkg --print-architecture`
+ JAVA_HOME="usr"
java_home can't really be defined as usr because it expect a specific directory layout.
It has to be /usr/lib/jvm/something
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Author
|
Updated |
mbaechler
approved these changes
Sep 11, 2017
Contributor
mbaechler
left a comment
mbaechler
left a comment
There was a problem hiding this comment.
It will need some squashing of commits but that's ok for me
Author
|
Thanks, I let you doing this ? |
Author
|
Hi, |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.