Skip to content

Conversation

@Kinngife
Copy link

4월 5일 진행한 html / css 자료 제출합니다.

Changes

  • 'index.html' 파일 추가
  • 'style.css' 파일 추가
  • 'README.md' 파일 수정

알록달록하게 꾸며봤습니다!

Copy link

@SehwanChang SehwanChang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다
LGTM!

4월 5일 세션에 대한 미니 프로젝트 과제를 제출하는 레포입니다.

교수님 미웡
안녕하세요 김기철입니다.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

같이 소공 화이팅해보아요

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

화이팅입니다~

Copy link

@kwonET kwonET left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

주석을 잘 이용한 것 같아요 !

<meta charset="UTF-8">
<meta http-equiv="X-UA-Compatible" content="IE=edge">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<script defer src="https://use.fontawesome.com/releases/v5.15.4/js/all.js" integrity="sha384-rOA1PnstxnOBLzCLMcre8ybwbTmemjzdNlILg8O7z1lUkLXozs4DHonlDtnE7fpc" crossorigin="anonymous"></script>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

무엇을 임포트한 것인가요?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

폰트어썸(테크잇에서 알려줬습니다.) 이라고 아이콘 추가하려고 추가했습니다.

Comment on lines +9 to +13
* {
box-sizing: border-box;
margin: 0;
}

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이곳에 font-family: 'GangwonEduSaeeum_OTFMediumA'를 지정해주면
아래 중복된 폰트에 관한 코드를 방지할 수 있을 것 같아요

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

동의합니다!

<div class="bg"></div>
<div id="title">[반려동물]</div>
<p>
고양이 <br>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

저도 고양이 키우고 싶어요 😭

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

추천합니다.!

Copy link

@wchan0409 wchan0409 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 확인부탁드립니다

이름 : 김기철<br>
포지션 : 프론트엔드<br>
학과 : 수학과<br>
생년월일 : 1999.12.17

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

저희 부모님이 처음 만나신 날이네요...TMI 죄송합니다

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

영광입니다...

Copy link

@taeho0888 taeho0888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

이름 : 김기철<br>
포지션 : 프론트엔드<br>
학과 : 수학과<br>
생년월일 : 1999.12.17

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

저랑 생일이 이틀 차이네요!! 생일 축하드립니다

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오 생일 축하드려요 ~ 15일인가요 19일인가요

Copy link

@go-the-extra-mile go-the-extra-mile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!

font-style: normal;
}

/* 전체 */

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CSS 파일을 잘 정리해둬서 보기 좋아요!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

감사합니다 수고하셨습니다~

README.md Outdated
# 11th_HTML-CSS
4월 5일 세션에 대한 미니 프로젝트 과제를 제출하는 레포입니다.

교수님 미웡

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(숨김처리된 라인입니다)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fork 했는데 저는 이 line이 있더라고여..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants