Closed
Conversation
Member
|
Have you see the builds? There is an issue with the composer dependencies... |
Contributor
|
I'm 👎 on adding this to composer. Imo php-cs-fixer should be installed locally, but this won't enforce the correct use of code style. So maybe it's an option to use a service like styleci.io which will check each pr and report issues with coding style (and provide a patch file) |
Author
|
@jeanmonod jeah, correct. I will check this later. |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding the php-cs-fixer with PSR2 styleguide
To let it run:
I also fixed two files that are not PSR2 formatted.
It would be nice to insert this into travis: