feat: use FQCN for fixtures and type checks

.gitignore

@@ -10,3 +10,4 @@ vendor
 !.gitkeep
 
 tests/App*/var/
+tests/App*/config/reference.php

doc/database.md

@@ -47,8 +47,8 @@ class MyControllerTest extends WebTestCase
 +        // add all your fixtures classes that implement
 +        // Doctrine\Common\DataFixtures\FixtureInterface
 +        $this->databaseTool->loadFixtures([
-+            'Bamarni\MainBundle\DataFixtures\ORM\LoadData',
-+            'Me\MyBundle\DataFixtures\ORM\LoadData'
++            \Bamarni\MainBundle\DataFixtures\ORM\LoadData:class,
++            \Me\MyBundle\DataFixtures\ORM\LoadData:class,
 +        ]);
 
         // you can now run your functional tests with a populated database
@@ -178,8 +178,8 @@ class MyControllerTest extends WebTestCase
         // add all your fixtures classes that implement
         // Doctrine\Common\DataFixtures\FixtureInterface
         $this->databaseTool->loadFixtures([
-            'Bamarni\MainBundle\DataFixtures\ORM\LoadData',
-            'Me\MyBundle\DataFixtures\ORM\LoadData'
+            \Bamarni\MainBundle\DataFixtures\ORM\LoadData::class,
+            \Me\MyBundle\DataFixtures\ORM\LoadData::class',
         ]);
 
         // you can now run your functional tests with a populated database
@@ -213,7 +213,7 @@ to the `setExcludedDoctrineTables` method before loading the fixtures.
 ```php
 $this->databaseTool->setExcludedDoctrineTables(['my_tablename_not_to_be_purged']);
 $this->databaseTool->loadFixtures([
-    'Me\MyBundle\DataFixtures\ORM\LoadData'
+    \Me\MyBundle\DataFixtures\ORM\LoadData::class,
 ]);
 ```
 

docker-compose.yml

@@ -1,4 +1,3 @@
-version: '3.1'
 services:
     mariadb:
         image: 'mariadb:11'

tests/App/DataFixtures/ORM/LoadDependentUserData.php

@@ -42,8 +42,8 @@ public function load(ObjectManager $manager): void
     public function getDependencies(): array
     {
         return [
-            'Liip\Acme\Tests\App\DataFixtures\ORM\LoadUserData',
-            'Liip\Acme\Tests\App\DataFixtures\ORM\LoadSettingData',
+            LoadUserData::class,
+            LoadSettingData::class,
         ];
     }
 }

tests/App/DataFixtures/ORM/LoadDependentUserWithServiceData.php

@@ -52,7 +52,7 @@ public function load(ObjectManager $manager): void
     public function getDependencies(): array
     {
         return [
-            'Liip\Acme\Tests\App\DataFixtures\ORM\LoadUserWithServiceData',
+            LoadUserWithServiceData::class,
         ];
     }
 }

tests/Test/ConfigEventsTest.php

@@ -13,6 +13,7 @@
 
 namespace Liip\Acme\Tests\Test;
 
+use Doctrine\Common\DataFixtures\Executor\ORMExecutor;
 use Liip\Acme\Tests\AppConfigEvents\AppConfigEventsKernel;
 use Liip\Acme\Tests\AppConfigEvents\EventListener\FixturesSubscriber;
 use Liip\TestFixturesBundle\LiipTestFixturesEvents;
@@ -57,7 +58,7 @@ public function testLoadEmptyFixturesAndCheckEvents(): void
         $fixtures = $databaseTool->loadFixtures([]);
 
         $this->assertInstanceOf(
-            'Doctrine\Common\DataFixtures\Executor\ORMExecutor',
+            ORMExecutor::class,
             $fixtures
         );
 
@@ -116,7 +117,7 @@ public function testLoadEmptyFixturesAndCheckEventsAreCalled(string $eventName,
         }
 
         $this->assertInstanceOf(
-            'Doctrine\Common\DataFixtures\Executor\ORMExecutor',
+            ORMExecutor::class,
             $fixtures
         );
     }

tests/Test/ConfigMysqlCacheDbTest.php

@@ -13,6 +13,8 @@
 
 namespace Liip\Acme\Tests\Test;
 
+use Liip\Acme\Tests\App\DataFixtures\ORM\LoadSecondUserData;
+use Liip\Acme\Tests\App\DataFixtures\ORM\LoadUserData;
 use Liip\Acme\Tests\App\Entity\User;
 use Liip\Acme\Tests\AppConfigMysqlCacheDb\AppConfigMysqlKernelCacheDb;
 use PHPUnit\Framework\Attributes\PreserveGlobalState;
@@ -45,7 +47,7 @@ protected function setUp(): void
     public function testLoadFixturesAndCheckBackup(): void
     {
         $this->databaseTool->loadFixtures([
-            'Liip\Acme\Tests\App\DataFixtures\ORM\LoadUserData',
+            LoadUserData::class,
         ]);
 
         // Load data from database
@@ -85,7 +87,7 @@ public function testLoadFixturesAndCheckBackup(): void
 
         // Load fixtures again
         $this->databaseTool->loadFixtures([
-            'Liip\Acme\Tests\App\DataFixtures\ORM\LoadUserData',
+            LoadUserData::class,
         ]);
 
         $users = $this->userRepository->findAll();
@@ -113,7 +115,7 @@ public function testLoadFixturesAndCheckBackup(): void
     public function testLoadFixturesCheckReferencesByClass(): void
     {
         $referenceRepository = $this->databaseTool->loadFixtures([
-            'Liip\Acme\Tests\App\DataFixtures\ORM\LoadUserData',
+            LoadUserData::class,
         ])->getReferenceRepository();
 
         $references = $referenceRepository->getReferencesByClass();
@@ -125,8 +127,8 @@ public function testLoadFixturesCheckReferencesByClass(): void
         $this->assertCount(1, $references[$className]);
 
         $referenceRepository = $this->databaseTool->loadFixtures([
-            'Liip\Acme\Tests\App\DataFixtures\ORM\LoadUserData',
-            'Liip\Acme\Tests\App\DataFixtures\ORM\LoadSecondUserData',
+            LoadUserData::class,
+            LoadSecondUserData::class,
         ])->getReferenceRepository();
 
         $references = $referenceRepository->getReferencesByClass();

tests/Test/ConfigMysqlTest.php

@@ -13,8 +13,13 @@
 
 namespace Liip\Acme\Tests\Test;
 
+use Doctrine\Common\DataFixtures\Executor\ORMExecutor;
+use Doctrine\Common\DataFixtures\ProxyReferenceRepository;
 use Doctrine\Common\DataFixtures\Purger\ORMPurger;
 use Doctrine\ORM\EntityRepository;
+use Liip\Acme\Tests\App\DataFixtures\ORM\LoadDependentUserData;
+use Liip\Acme\Tests\App\DataFixtures\ORM\LoadSecondUserData;
+use Liip\Acme\Tests\App\DataFixtures\ORM\LoadUserData;
 use Liip\Acme\Tests\App\Entity\Setting;
 use Liip\Acme\Tests\App\Entity\User;
 use Liip\Acme\Tests\AppConfigMysql\AppConfigMysqlKernel;
@@ -83,7 +88,7 @@ public function testLoadEmptyFixtures(): void
         $fixtures = $this->databaseTool->loadFixtures([]);
 
         $this->assertInstanceOf(
-            'Doctrine\Common\DataFixtures\Executor\ORMExecutor',
+            ORMExecutor::class,
             $fixtures
         );
     }
@@ -95,18 +100,18 @@ public function testLoadEmptyFixtures(): void
     public function testLoadFixtures(): void
     {
         $fixtures = $this->databaseTool->loadFixtures([
-            'Liip\Acme\Tests\App\DataFixtures\ORM\LoadUserData',
+            LoadUserData::class,
         ]);
 
         $this->assertInstanceOf(
-            'Doctrine\Common\DataFixtures\Executor\ORMExecutor',
+            ORMExecutor::class,
             $fixtures
         );
 
         $repository = $fixtures->getReferenceRepository();
 
         $this->assertInstanceOf(
-            'Doctrine\Common\DataFixtures\ProxyReferenceRepository',
+            ProxyReferenceRepository::class,
             $repository
         );
 
@@ -136,12 +141,12 @@ public function testLoadFixtures(): void
     public function testAppendFixtures(): void
     {
         $this->databaseTool->loadFixtures([
-            'Liip\Acme\Tests\App\DataFixtures\ORM\LoadUserData',
+            LoadUserData::class,
         ]);
 
         $referenceRepository = $this->databaseTool->loadFixtures(
-            ['Liip\Acme\Tests\App\DataFixtures\ORM\LoadSecondUserData'],
-            true
+            [LoadSecondUserData::class],
+            true,
         )->getReferenceRepository();
 
         $references = $referenceRepository->getReferencesByClass();
@@ -208,16 +213,17 @@ public function testAppendFixtures(): void
      * Data fixtures and purge.
      *
      * Purge modes are defined in
-     * Doctrine\Common\DataFixtures\Purger\ORMPurger.
+     *
+     * @see ORMPurger
      */
     public function testLoadFixturesAndExcludeFromPurge(): void
     {
         $fixtures = $this->databaseTool->loadFixtures([
-            'Liip\Acme\Tests\App\DataFixtures\ORM\LoadUserData',
+            LoadUserData::class,
         ]);
 
         $this->assertInstanceOf(
-            'Doctrine\Common\DataFixtures\Executor\ORMExecutor',
+            ORMExecutor::class,
             $fixtures
         );
 
@@ -244,19 +250,20 @@ public function testLoadFixturesAndExcludeFromPurge(): void
      * Data fixtures and purge.
      *
      * Purge modes are defined in
-     * Doctrine\Common\DataFixtures\Purger\ORMPurger.
+     *
+     * @see ORMPurger
      *
      * @group mysql
      * @group pgsql
      */
     public function testLoadFixturesAndPurge(): void
     {
         $fixtures = $this->databaseTool->loadFixtures([
-            'Liip\Acme\Tests\App\DataFixtures\ORM\LoadUserData',
+            LoadUserData::class,
         ]);
 
         $this->assertInstanceOf(
-            'Doctrine\Common\DataFixtures\Executor\ORMExecutor',
+            ORMExecutor::class,
             $fixtures
         );
 
@@ -283,7 +290,7 @@ public function testLoadFixturesAndPurge(): void
 
         // Reload fixtures
         $this->databaseTool->loadFixtures([
-            'Liip\Acme\Tests\App\DataFixtures\ORM\LoadUserData',
+            LoadUserData::class,
         ]);
 
         $users = $this->userRepository->findAll();
@@ -358,11 +365,11 @@ public function testLoadFixturesFiles(): void
     public function testLoadDependentFixtures(): void
     {
         $fixtures = $this->databaseTool->loadFixtures([
-            'Liip\Acme\Tests\App\DataFixtures\ORM\LoadDependentUserData',
+            LoadDependentUserData::class,
         ]);
 
         $this->assertInstanceOf(
-            'Doctrine\Common\DataFixtures\Executor\ORMExecutor',
+            ORMExecutor::class,
             $fixtures
         );
 

tests/Test/ConfigPgsqlCacheDbTest.php

@@ -14,6 +14,8 @@
 namespace Liip\Acme\Tests\Test;
 
 use Doctrine\Common\Annotations\Annotation\IgnoreAnnotation;
+use Liip\Acme\Tests\App\DataFixtures\ORM\LoadSecondUserData;
+use Liip\Acme\Tests\App\DataFixtures\ORM\LoadUserData;
 use Liip\Acme\Tests\App\Entity\User;
 use Liip\Acme\Tests\AppConfigPgsqlCacheDb\AppConfigPgsqlKernelCacheDb;
 
@@ -53,7 +55,7 @@ public function testLoadFixturesAndCheckBackup(): void
         $this->assertTrue($this->databaseTool->isDatabaseCacheEnabled());
 
         $this->databaseTool->loadFixtures([
-            'Liip\Acme\Tests\App\DataFixtures\ORM\LoadUserData',
+            LoadUserData::class,
         ]);
 
         // Load data from database
@@ -93,7 +95,7 @@ public function testLoadFixturesAndCheckBackup(): void
 
         // Load fixtures again
         $this->databaseTool->loadFixtures([
-            'Liip\Acme\Tests\App\DataFixtures\ORM\LoadUserData',
+            LoadUserData::class,
         ]);
 
         $users = $this->userRepository->findAll();
@@ -124,7 +126,7 @@ public function testLoadFixturesAndCheckBackup(): void
     public function testLoadFixturesCheckReferences(): void
     {
         $referenceRepository = $this->databaseTool->loadFixtures([
-            'Liip\Acme\Tests\App\DataFixtures\ORM\LoadUserData',
+            LoadUserData::class,
         ])->getReferenceRepository();
 
         $references = $referenceRepository->getReferencesByClass();
@@ -136,8 +138,8 @@ public function testLoadFixturesCheckReferences(): void
         $this->assertCount(1, $references[$className]);
 
         $referenceRepository = $this->databaseTool->loadFixtures([
-            'Liip\Acme\Tests\App\DataFixtures\ORM\LoadUserData',
-            'Liip\Acme\Tests\App\DataFixtures\ORM\LoadSecondUserData',
+            LoadUserData::class,
+            LoadSecondUserData::class,
         ])->getReferenceRepository();
 
         $references = $referenceRepository->getReferencesByClass();