Skip to content

Conversation

guggero
Copy link
Contributor

@guggero guggero commented Aug 11, 2025

Some questions by @ZZiigguurraatt made me realize we didn't previously test the new addresses in a chain re-org scenario.

Makes sure that chain re-orgs don't negatively impact sends with v2
addresses and that the re-org watcher does its job normally, independent
of the address version used.
@guggero guggero marked this pull request as ready for review August 11, 2025 11:16
@guggero guggero self-assigned this Aug 11, 2025
@guggero guggero requested review from ffranr and GeorgeTsagk August 11, 2025 11:17
@guggero guggero added this to the v0.7 milestone Aug 11, 2025
@guggero guggero moved this from 🆕 New to 👀 In review in Taproot-Assets Project Board Aug 11, 2025
@coveralls
Copy link

coveralls commented Aug 11, 2025

Pull Request Test Coverage Report for Build 16878463788

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 8873 unchanged lines in 118 files lost coverage.
  • Overall coverage increased (+0.01%) to 56.629%

Files with Coverage Reduction New Missed Lines %
authmailbox/client.go 2 69.84%
commitment/proof.go 2 87.29%
fn/retry.go 2 92.5%
tapdb/interfaces.go 2 80.83%
tapsend/proof.go 2 85.99%
fn/recv.go 3 65.12%
universe/interface.go 3 60.63%
commitment/encoding.go 4 68.75%
rpcutils/price_oracle_marshal.go 4 85.07%
rfqmsg/messages.go 5 85.52%
Totals Coverage Status
Change from base Build 16872621250: 0.01%
Covered Lines: 60543
Relevant Lines: 106912

💛 - Coveralls

@guggero guggero requested review from jtobin and removed request for ffranr August 13, 2025 08:38
Copy link
Member

@jtobin jtobin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wound up spending quite a bit of time with this to better-understand the itest mechanics. LGTM 👍

@guggero guggero merged commit 88bb940 into main Aug 13, 2025
35 of 38 checks passed
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Taproot-Assets Project Board Aug 13, 2025
@guggero guggero deleted the address-v2-re-org branch August 20, 2025 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

4 participants