Delete channel alias scids when quotes expire #1710
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ffranr
reviewed
Aug 6, 2025
Comment on lines
+889
to
+892
| // Start the main event loop in a separate go routine. | ||
| h.Wg.Add(1) | ||
| go func() { | ||
| defer h.Wg.Done() |
There was a problem hiding this comment.
we could use h.ContextGuard.Goroutine here (and above if you like)
|
Need to bump configured go version to |
GeorgeTsagk
force-pushed
the
delete-expired-scids
branch
from
cc99a90 to
5a74347
Compare
We use the new LND RPC endpoint that looks up the base scid for an alias, in order to use it to delete the mapping shortly after. In addition we break the order handler main loop into it's go routine, which was previously never really running as it followed the HTLC interceptor setup which was a blocking call.
GeorgeTsagk
force-pushed
the
delete-expired-scids
branch
from
5a74347 to
08f114e
Compare
Pull Request Test Coverage Report for Build 16778492979Details
💛 - Coveralls |
|
For the LiT tests I'll have to make a PR that bumps all versions that are included with this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously when we'd garbage collect quotes we'd only delete the quote entry locally on tapd. What we didn't do is clear the state that was produced in LND, which keeps track of alias scid -> base scid mappings to facilitate routing.
We use the new method
XFindBaseLocalChanAliasto retrieve the base scid that corresponds to our quotes, and then we call LND to delete the alias.Depends on:
lightningnetwork/lnd#10133
lightninglabs/lndclient#236