itest: fix flakes #1705
Merged
itest: fix flakes #1705
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an itest case where shutting down the client before a server connection to the auth mailbox server could be established lead to the cancellation being treated as a critical error, causing the test to fail.
When CPU cycles are constrained (e.g. in CI), it can sometimes happen that we: - Import a proof into the multi archiver - The multi archiver imports it into each backend - The first backend notifies its subscribers after importing - The custodian reacts to the notification and checks HasProof on the multi archiver - Because the other goroutine hasn't finished importing into all backends, HasProof returns false - The custodian only finishes the transfer once it receives the notification from the second backend All the above leads to the situation where the status "proof received" is fired twice instead of just once, which causes the itests to fail sometimes.
Pull Request Test Coverage Report for Build 16753041762Details
💛 - Coveralls |
ffranr
approved these changes
Aug 5, 2025
GeorgeTsagk
approved these changes
Aug 5, 2025
github-project-automation
bot
moved this from 🆕 New
to 👀 In review
in Taproot-Assets Project Board
github-project-automation
bot
moved this from 👀 In review
to ✅ Done
in Taproot-Assets Project Board
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes three issues with the integration tests that only surface sometimes.