Use new NoopAddHtlc TLV when sending assets with default above-dust anchor amt #1567
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 15278104744Details
💛 - Coveralls |
Roasbeef
requested changes
May 28, 2025
| @@ -135,6 +143,11 @@ func (h *Htlc) Records() []tlv.Record { | |||
| records = append(records, r.Record()) | |||
| }) | |||
|
|
|||
| if h.NoopAdd { | |||
| r := tlv.NewPrimitiveRecord[lnwallet.NoopAddHtlcType](true) | |||
There was a problem hiding this comment.
Another thing to update in the bLIPs.
| return totalAmount, htlcCustomRecords, nil | ||
|
|
||
| htlc.SetNoopAdd() | ||
| updatedRecords, err := htlc.ToCustomRecords() |
There was a problem hiding this comment.
Seems the aspect related to the reserve that you mentioned isn't in this PR yet?
There was a problem hiding this comment.
It's not updated yet and it's on the LND PR, here we don't really have access to the channel state so we only decide whether we flag the noop to LND or not
levmi
added
payment-channel
premature-exhaustion
|
@GeorgeTsagk, remember to re-request review from reviewers when ready |
We add a new noop flag to the HTLC which, when set, will produce the corresponding TLV record. We also hide this feature behind the dev flag, as we ultimately want to be backwards compatible via some feature bit related peer messages.
Since we now have two different candidate types for adding HTLCs, we use the helper method that checks against both of them.
Whenever we use the default above-dust anchor amount to send an HTLC with assets we also set the noop flag on the HTLC, which will produce the according noop HTLC record and signal to LND that the satoshi amount should be returned to the sender.
GeorgeTsagk
force-pushed
the
noop-add-tlv
branch
from
f6a1db8 to
723311b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When sending HTLCs that carry assets we now set the noop flag whenever the amount is the default anchor amount. Since that amount is mandatory for the anchoring of assets we want to keep it around while HTLCs are inflight, but not actually send it to the channel counter party when the HTLC settles. This is exactly what the noop flag triggers.
The feature is currently hidden behind the
go:build devflag, as it will break backwards compatibility if used by default. This will be the case until we introduce feature related peer messages for custom channels.Closes #888
Closes #1305