-
Notifications
You must be signed in to change notification settings - Fork 132
Updated ListAssetRequest to include additional filter options #1199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
84ac4c8
to
b6e90aa
Compare
f31d9f4
to
f189364
Compare
Pull Request Test Coverage Report for Build 14571628881Details
💛 - Coveralls |
f189364
to
ccf4b76
Compare
6abd778
to
3c0141b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good!
it's in the right direction 💯
13eabd1
to
241d98d
Compare
f5d1985
to
9c7b7e9
Compare
9c7b7e9
to
4566b97
Compare
c74c44a
to
8b0d382
Compare
8b0d382
to
6951f28
Compare
@GeorgeTsagk @guggero I updated the code to filter assets based on the tweaked script key instead of the internal script key ID. I ran into some weird issues with the automated tests, for some reason I was unable to filter the 10th asset:
Oli said this might have something to do with an underlying issue with the specific anchor point or asset generation, but I'm not sure why this particular asset is "cursed" 😅 I worked around the issue by adding a script key to the 3rd asset and was able to filter it as expected. |
6951f28
to
856d9e3
Compare
856d9e3
to
cf0ef8e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
super close 💯
mostly styling related comments
should also add the filter options to the cmd command but since they weren't there in the first place this can be done in a different PR
517d54a
to
402d754
Compare
a2be556
to
402d754
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there.
@GeorgeTsagk: review reminder |
402d754
to
3241ca0
Compare
3241ca0
to
ebd4f4a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, LGTM 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ty!
Resolves #876
This PR adds new filter options to the
ListAssets
RPC call.ListAssetRequest
proto definition was updated to include the new filter options.fetchRpcAssets
function was refactored to accept aAssetQueryFilters
argument so that separate arguments don't need to be added for each filter option.constraintsToDbFilter
function was updated to use the new filter options.assets.sql
file was updated to include a newmaxAmount
option.