Fix update_id gap during force_shutdown
#3858
Open
+9
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 I see @jkczyz was un-assigned. |
wpaulino
reviewed
Jun 13, 2025
There was a problem hiding this comment.
Thanks! This should work, but do you mind including a test?
There are other scenarios where we also increment by 1, but those should not result in a panic as they are queued in blocked_monitor_updates. The force close update is the only one we let fly through regardless of blocked_monitor_updates.
When a channel is force-closed, there might be blocked monitor updates not yet applied. But `latest_monitor_update_id` has been incremented and assigned to these updates. This results in a panic when trying to apply the `ChannelForceClosed` update. Use the unblocked update id instead. Resolves: lightningdevkit#3857
whfuyn
force-pushed
the
fix-update-id-gap
branch
from
446155b to
5e6e74c
Compare
|
Got it! Will add a test later. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3858 +/- ##
==========================================
- Coverage 89.94% 89.91% -0.04%
==========================================
Files 163 163
Lines 131655 131652 -3
Branches 131655 131652 -3
==========================================
- Hits 118421 118371 -50
- Misses 10550 10583 +33
- Partials 2684 2698 +14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
TheBlueMatt
approved these changes
Jun 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a channel is force-closed, there might be blocked monitor updates not yet applied. But
latest_monitor_update_idhas been incremented and assigned to these updates. This results in a panic when trying to apply theChannelForceClosedupdate. Use the unblocked update id instead.Resolves: #3857