Hook up ChannelConfig in open channel endpoint & add to cli #81
Conversation
|
👋 I see @tnull was un-assigned. |
Hmm, I think context might be lightningdevkit/ldk-node#385 / #16 (comment). Do you think it's fine to move ahead as-is now, or do we really need ldk-node#385? If not, can we close the latter for now? |
|
I saw that todo but it seemed separate. That is for updating the channel config, not setting it on open |
ldk-server-cli/src/main.rs
Outdated
| #[arg(long, help = "Forwarding fee proportional (in millionths of a satoshi)")] | ||
| forwarding_fee_proportional_millionths: Option<u32>, | ||
| #[arg(long, help = "Forwarding fee base (in milli-satoshi)")] | ||
| forwarding_fee_base_msat: Option<u32>, | ||
| #[arg(long, help = "CLTV expiry delta")] | ||
| cltv_expiry_delta: Option<u32>, | ||
| #[arg(long, help = "Force close avoidance max fee (in satoshis)")] | ||
| force_close_avoidance_max_fee_satoshis: Option<u64>, | ||
| #[arg(long, help = "Accept underpaying HTLCs")] | ||
| accept_underpaying_htlcs: Option<bool>, | ||
| #[arg( | ||
| long, | ||
| help = "Max dust HTLC exposure as fixed limit (in milli-satoshi)", | ||
| conflicts_with = "max_dust_htlc_fee_rate_multiplier" | ||
| )] | ||
| max_dust_htlc_fixed_limit_msat: Option<u64>, | ||
| #[arg( | ||
| long, | ||
| help = "Max dust HTLC exposure as fee rate multiplier", | ||
| conflicts_with = "max_dust_htlc_fixed_limit_msat" | ||
| )] | ||
| max_dust_htlc_fee_rate_multiplier: Option<u64>, |
There was a problem hiding this comment.
Some of these options could really use some more documentation, but at the same time, I wouldn't expect users to set these in most cases. Maybe we just keep the forwarding specific ones for now and revisit the others if there's interest from users?
There was a problem hiding this comment.
Added more docs and removed some of the options that doesn't really make sense for users
benthecarman
force-pushed
the
open-channel-cfg
branch
from
5dc39d2 to
3fd7800
Compare
These were available on the server side but not in the cli. Not all options are given as they aren't likely to be used and more likely to be confusing to users.
benthecarman
force-pushed
the
open-channel-cfg
branch
from
3fd7800 to
22cae11
Compare
4 participants
We had this in the proto files but was not hooked up on the server side or on the cli. This adds it on both ends