Skip to content

Add splicing RPCs and CLI commands #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tnull merged 1 commit into from
Dec 11, 2025
Merged

Add splicing RPCs and CLI commands #73

tnull merged 1 commit into from
Dec 11, 2025

Conversation

@jkczyz
Copy link
Contributor

@jkczyz jkczyz commented Oct 30, 2025

Based on #72.

@ldk-reviews-bot
Copy link

ldk-reviews-bot commented Oct 30, 2025 •
edited
Loading

👋 Thanks for assigning @tnull as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

@jkczyz jkczyz self-assigned this Oct 30, 2025
@tnull tnull self-requested a review October 30, 2025 17:39
@ldk-reviews-bot
Copy link

ldk-reviews-bot commented Nov 3, 2025

🔔 1st Reminder

Hey @tnull! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

@ldk-reviews-bot
Copy link

ldk-reviews-bot commented Nov 5, 2025

🔔 2nd Reminder

Hey @tnull! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

@ldk-reviews-bot
Copy link

ldk-reviews-bot commented Nov 8, 2025

🔔 3rd Reminder

Hey @tnull! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

@ldk-reviews-bot
Copy link

ldk-reviews-bot commented Nov 10, 2025

🔔 4th Reminder

Hey @tnull! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

@ldk-reviews-bot
Copy link

ldk-reviews-bot commented Nov 12, 2025

🔔 5th Reminder

Hey @tnull! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

@ldk-reviews-bot
Copy link

ldk-reviews-bot commented Nov 15, 2025

🔔 6th Reminder

Hey @tnull! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

@ldk-reviews-bot
Copy link

ldk-reviews-bot commented Nov 17, 2025

🔔 7th Reminder

Hey @tnull! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

tnull
tnull reviewed Nov 17, 2025
View reviewed changes
@jkczyz jkczyz force-pushed the 2025-10-splicing branch 4 times, most recently from 8eb5cb1 to 19f6023 Compare December 10, 2025 15:01
@jkczyz jkczyz marked this pull request as ready for review December 10, 2025 15:02
@jkczyz jkczyz requested a review from tnull December 10, 2025 15:02
tnull
tnull previously approved these changes Dec 11, 2025
View reviewed changes
Copy link
Collaborator

@tnull tnull left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One non-blocking nit, otherwise LGTM.

Feel free to land as-is.

ldk-server/src/api/splice_channel.rs Outdated
.map_err(|_| {
LdkServerError::new(
InvalidRequestError,
"Address is not valid for LdkServer's configured network.".to_string(),
Copy link
Collaborator

@tnull tnull Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit:

Suggested change
"Address is not valid for LdkServer's configured network.".to_string(),
"Address is not valid for the configured network.".to_string(),

(or "LDK Server").

@jkczyz jkczyz requested a review from tnull December 11, 2025 15:34
@jkczyz
Copy link
Contributor Author

jkczyz commented Dec 11, 2025

One non-blocking nit, otherwise LGTM.

Feel free to land as-is.

Fixed, though looks it will need another approval.

@tnull tnull merged commit 2c24f68 into lightningdevkit:main Dec 11, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tnull tnull tnull approved these changes

Assignees

@jkczyz jkczyz

Labels

None yet

Projects

Weekly Goals
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jkczyz @ldk-reviews-bot @tnull