Skip to content

Update main post v0.5.0 release #532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tnull merged 2 commits into from
Apr 29, 2025
Merged

Update main post v0.5.0 release #532

tnull merged 2 commits into from
Apr 29, 2025

Conversation

@tnull
Copy link
Collaborator

@tnull tnull commented Apr 29, 2025

We update our main branch after the release in #530 shipped.

@tnull tnull requested a review from joostjager April 29, 2025 08:15
@ldk-reviews-bot
Copy link

ldk-reviews-bot commented Apr 29, 2025 •
edited
Loading

👋 Thanks for assigning @joostjager as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

joostjager
joostjager approved these changes Apr 29, 2025
View reviewed changes
CHANGELOG.md
@@ -1,3 +1,60 @@
# 0.5.0 - Apr. 29, 2025
Copy link
Contributor

@joostjager joostjager Apr 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q about ordering. Shouldn't this PR have been merged first into main, and then branch the release PR off of the first commit with this change log?

Copy link
Collaborator Author

@tnull tnull Apr 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, well, usually the release PRs also include upgraded binary files, which is why I usually create and merge them first.

Copy link
Contributor

@joostjager joostjager Apr 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even with a release PR with upgraded binaries, you could still merge the change log into main first? On the other hand, it's nice for a release PR to contain the change log, that's probably more true.

@tnull tnull merged commit a98747d into lightningdevkit:main Apr 29, 2025
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joostjager joostjager joostjager approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tnull @ldk-reviews-bot @joostjager