Fix: add retry logic to Esplora requests to handle connection issues #513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 This PR is now ready for review! |
tnull
reviewed
Mar 28, 2025
Collaborator
tnull
left a comment
tnull
left a comment
There was a problem hiding this comment.
Thanks for taking a look at this!
|
👋 The first review has been submitted! Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer. |
alexanderwiederin
force-pushed
the
fix-flaky-python-test
branch
2 times, most recently
from
9225712 to
0704414
Compare
- Add timeout, max retries, and error handling to wait_for_block and wait_for_tx functions in Python tests - Catch and log connection errors instead of failing immediately - Use shorter sleep interval (0.5s) to match Kotlin implementation - Add error messages during retries This addresses the "Connection reset by peer" errors in CI by making the Python tests more resilient to temporary network issues when connecting to the Esplora API.
alexanderwiederin
force-pushed
the
fix-flaky-python-test
branch
from
0704414 to
ce34d7e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Esplora connection issues in Python tests
Description
This PR addresses the intermittent CI failures in Python tests where connection to the Esplora server was being reset ("Connection reset by peer" errors).
Changes
These changes will make our CI pipeline more stable and reduce false negative test failures.