Skip to content

fix: update font loading to use platform fetch abstraction #768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wouterlucas merged 1 commit into from
Apr 7, 2026
Merged

fix: update font loading to use platform fetch abstraction #768

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions src/core/text-rendering/SdfFontHandler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,14 +302,11 @@ export const loadFont = async (
const nwff: CoreTextNode[] = (nodesWaitingForFont[fontFamily] = []);
// Create loading promise
const loadPromise = (async (): Promise<void> => {
// Load font JSON data
const response = await fetch(atlasDataUrl);
if (!response.ok) {
throw new Error(`Failed to load font data: ${response.statusText}`);
}

const fontData = (await response.json()) as SdfFontData;
if (!fontData || !fontData.chars) {
// Load font JSON data via the platform's fetch abstraction so behaviour
// can be overridden per platform (XHR, Fetch API, custom loaders, etc.).
const blob = (await stage.platform.fetch(atlasDataUrl)) as Blob;
const fontData = JSON.parse(await blob.text()) as SdfFontData;
if (fontData === null || fontData.chars === undefined) {
throw new Error('Invalid SDF font data format');
}

Expand Down
Loading