Skip to content

Add grid item size control to MCAP grid view - #2445

Open
LeonardoRosaa wants to merge 1 commit into
mainfrom
leonardo-lig-10928-add-grid-item-size-slider-to-mcap-sequence-grid-view
Open

LeonardoRosaa wants to merge 1 commit into
mainfrom
leonardo-lig-10928-add-grid-item-size-slider-to-mcap-sequence-grid-view

Conversation

@LeonardoRosaa

@LeonardoRosaa LeonardoRosaa commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

What has changed and why?

Adds a grid item size slider to the MCAP grid view.

Screenshot 2026-09-21 at 11 18 55

How has it been tested?

  • Executed example_mcap.py example file

Did you update CHANGELOG.md?

  • Yes
  • Not needed (internal change)

Summary by CodeRabbit

  • New Features

    • Added support for point-cloud collections in grid views, including grid headers, side-panel tabs, and selection controls.
    • Point-cloud grids now display without a filter panel.
  • Bug Fixes

    • Prevented filter-panel controls from appearing on point-cloud collection routes.
  • Tests

    • Added coverage verifying that filter panels are hidden for point-cloud workspaces.

@coderabbitai

coderabbitai Bot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

Understand this PR’s impact

Explore downstream dependencies and potential security impact with Blast Radius.

View blast radius →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Advanced

Run ID: 5fdc68f2-6a30-4a30-b993-6816b00146f0

📥 Commits

Reviewing files that changed from the base of the PR and between ad1b071 and 237a8db.

📒 Files selected for processing (2)
  • lightly_studio_view/src/routes/datasets/[dataset_id]/[collection_type]/[collection_id]/+layout.svelte
  • lightly_studio_view/src/routes/datasets/[dataset_id]/[collection_type]/[collection_id]/layout.workspace.test.ts

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.


📝 Walkthrough

Walkthrough

Point-cloud routes now use collection-grid behavior without rendering the filter panel. A workspace test verifies that the filter panel is absent on point-cloud routes.

Changes

Point-cloud collection grid

Layer / File(s) Summary
Grid and filter-panel behavior
lightly_studio_view/src/routes/datasets/[dataset_id]/[collection_type]/[collection_id]/+layout.svelte, lightly_studio_view/src/routes/datasets/[dataset_id]/[collection_type]/[collection_id]/layout.workspace.test.ts
The layout identifies point-cloud routes as collection grids. It renders the filter panel and show-filters button only for other grid types. The workspace test verifies that filter-panel-body is not rendered for point-cloud routes.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Feature

Suggested reviewers: ikondrat

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title describes adding a grid item size control to the MCAP grid view, but the changeset adds point-cloud collection grid support and hides the filter panel for point-cloud routes. Update the title to describe the actual changes, such as excluding the filter panel from point-cloud collection grids.
Description check ⚠️ Warning The description includes all required template sections, explains the intended change, documents testing, and records the changelog decision. However, it does not match the summarized changeset, which… Rewrite the description to document the point-cloud grid layout changes, the filter-panel behavior, and the added workspace test. Update the testing section with the relevant test command and result.
✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description includes all required template sections, explains the intended change, documents testing, and records the changelog decision. However, it does not match the summarized changeset, which concerns point-cloud grid support and filter-panel rendering.

  • Fix all pre-merge checks with AI
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-21T14:21:48.763868Z 237a8db PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@lightly-fast-track-bot

Copy link
Copy Markdown

✅  Fast Track: all required checks passed — auto-approved.

Guardrail Result Message
frontend/complexity 2 file(s) checked, no violations.
backend/complexity 0 file(s) checked.
backend/coverage 0 file(s) checked.
diff-size PR adds 14 line(s) (limit: 215).
frontend/coverage 1 file(s) checked at 90%.
[PASS] lightly_studio_view/src/routes/datasets/[dataset_id]/[collection_type]/[collection_id]/+layout.svelte: 100.0%

View the guardrail run

To run the guardrails locally, from fast_track/ run make install once, then make run-guardrails (or GUARDRAILS=<name1>,<name2> make run-guardrails for some guardrails).

Reflects 237a8db.

@LeonardoRosaa

Copy link
Copy Markdown
Contributor Author

/review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant