Support for newer version #8
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New version of read header that works with newer SIF files that put XML at the end. However I had to remove the bit on spectral information as it didn't work with my files.
Update sifreader.py
Added dependencies
Owner
Hi mryzmo, Sorry I no longer have access to the sif files. I can either transfer the project ownership to you or direct to you repo in the readme file. Please let me know which one works better for you. Best, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for a new version of SIF-files that have XML in the end.
However I removed the spectrum support, since my files didn't have that and I couldn't test it. Perhaps you can see if you can merge it and test it with spectrum support on your files.
Otherwise, just close this :)
/Yzmo