Allow all subclasses of listed exceptions to be raised without violating contract #143
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pretty breaking change, but I made the PR just to start the discussion.
Imo it makes very little sense to not allow subclasses. I am using many third-party libraries, and basically all of them provide an exception hierarchy, for example SQLAlchemy has around 10 exception subclasses of
SQLAlchemyError. Of course, it would be best if I rewrap the exceptions again, but I really want to just tell deal and the consumers of my function that it may raise any subclass ofSQLAlchemyErrorand live on with my life, without listing out all the subclasses ofSQLAlchemyError.Tests were ran, same results on master and this branch (all 3 tests in test_mem_test.py failing)