test: VaultHub/StakingVault integration #1609
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkolpakov
changed the title
|
Hardhat Unit Tests Coverage SummaryDetailsDiff against masterResults for commit: 3c92e40 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
There was a problem hiding this comment.
Pull request overview
This PR adds comprehensive integration tests for VaultHub/StakingVault functionality, focusing on edge cases and critical behavior scenarios. The tests cover withdrawable value guard rails, obligations shortfall handling, forced validator exits, ownership transfers, share management, and vault enumeration.
Key changes:
- Integration tests for withdrawable value calculation under various conditions (pending disconnect, redemption obligations)
- Ownership transfer tests covering access control, state preservation, and edge cases
- Share transfer and burning tests validating liability and balance updates
- Forced validator exit tests for obligations shortfall scenarios
- Vault enumeration tests for counting and indexing behavior
- Bad debt internalization test case addition
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
test/integration/vaults/vaulthub.withdrawable-value.integration.ts |
Tests withdrawable value returns 0 during pending disconnect and when redemption obligations exceed balance |
test/integration/vaults/vaulthub.transfer-ownership.integration.ts |
Tests vault ownership transfer functionality including access control, state preservation, and various edge cases |
test/integration/vaults/vaulthub.transfer-and-burn-shares.integration.ts |
Tests share transfer and burning operations with liability tracking and balance validation |
test/integration/vaults/vaulthub.obligations-shortfall.integration.ts |
Tests that obligations shortfall correctly returns 0 after vault disconnection |
test/integration/vaults/vaulthub.force-validator-exit.integration.ts |
Tests forced validator exit functionality when obligations shortfall exists and redemption share reduction |
test/integration/vaults/vaulthub.enumeration.integration.ts |
Tests vault counting and indexing functions including behavior during disconnections |
test/integration/vaults/bad-debt.integration.ts |
Adds test case verifying bad debt is not internalized when vault value covers liabilities |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
test/integration/vaults/vaulthub.transfer-ownership.integration.ts
Outdated
Show resolved
Hide resolved
rkolpakov
force-pushed
the
feat/vaulhub-staking-vault-integration-tests
branch
from
96f91a9 to
f7062bf
Compare
rkolpakov
force-pushed
the
feat/vaulhub-staking-vault-integration-tests
branch
from
f7062bf to
9153436
Compare
folkyatina
approved these changes
Dec 14, 2025
tamtamchik
approved these changes
Dec 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integration tests for VaultHub/StakingVault edge cases covering withdrawable guard rails, obligations shortfall, forced exits, and rebalance balance flow