Happy path paused pdg #1605
Merged
Happy path paused pdg #1605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hardhat Unit Tests Coverage SummaryDetailsDiff against masterResults for commit: 5052a23 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
failingtwice
force-pushed
the
happy-path-paused-pdg
branch
from
6867a80 to
c159bf8
Compare
There was a problem hiding this comment.
Pull request overview
This PR adds a comprehensive integration test for vaults operating with the PredepositGuarantee (PDG) system paused. The test validates that vaults can still function through their complete lifecycle using alternative deposit mechanisms when PDG is unavailable.
Key Changes:
- Adds a 1559-line integration test covering the full vault lifecycle with PDG paused
- Tests unguaranteed deposits and side deposits as alternatives to PDG-guaranteed deposits
- Verifies all PDG operations are properly blocked when the system is paused
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
test/integration/vaults/scenario/pdg-paused-happy-path.integration.ts
Outdated
Show resolved
Hide resolved
tamtamchik
previously approved these changes
Dec 13, 2025
Member
tamtamchik
left a comment
tamtamchik
left a comment
There was a problem hiding this comment.
👏 👏 👏 Splendid! Some minor comments, but ready to merge as it is!
test/integration/vaults/scenario/pdg-paused-happy-path.integration.ts
Outdated
Show resolved
Hide resolved
test/integration/vaults/scenario/pdg-paused-happy-path.integration.ts
Outdated
Show resolved
Hide resolved
test/integration/vaults/scenario/pdg-paused-happy-path.integration.ts
Outdated
Show resolved
Hide resolved
tamtamchik
approved these changes
Dec 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a happy path scenario for vaults with PDG paused