Improve vault s happy path test #1604
Merged
+42
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hardhat Unit Tests Coverage SummaryDiff against masterResults for commit: b768b14 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Optional unpause of PDG in tests
There was a problem hiding this comment.
Pull request overview
This PR improves test organization by moving the ensurePredepositGuaranteeUnpaused call from global protocol context setup to individual test files. It also extends the vault's happy path test with additional test cases for ownership transfer and withdrawal functionality.
- Removes global
ensurePredepositGuaranteeUnpausedcall fromgetProtocolContextto allow better test isolation - Adds explicit
ensurePredepositGuaranteeUnpausedcalls to each test file that requires the predeposit guarantee to be unpaused - Adds new test cases for vault ownership transfer and withdrawal in the happy path scenario
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
lib/protocol/context.ts |
Removes the global ensurePredepositGuaranteeUnpaused call and its import from the context initialization |
test/integration/vaults/scenario/pdg-deposit.integration.ts |
Adds explicit call to ensurePredepositGuaranteeUnpaused before test setup |
test/integration/vaults/scenario/node-operator.happy-path.integration.ts |
Adds explicit call to ensurePredepositGuaranteeUnpaused in the test setup |
test/integration/vaults/scenario/happy-path.integration.ts |
Adds ensurePredepositGuaranteeUnpaused call and two new test cases for ownership transfer and withdrawal |
test/integration/vaults/pdg.integration.ts |
Adds explicit call to ensurePredepositGuaranteeUnpaused before test setup |
test/integration/vaults/gate-seal-pause.integration.ts |
Adds ensurePredepositGuaranteeUnpaused calls to multiple test cases that verify pausing functionality |
test/integration/vaults/disconnected.integration.ts |
Adds ensurePredepositGuaranteeUnpaused call in the deposits test section setup |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tamtamchik
approved these changes
Dec 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.