Skip to content

Conversation

@ItsDang
Copy link
Contributor

@ItsDang ItsDang commented Feb 27, 2025

For #815 Point 3, Coloring in the Computer Analysis Summary page.

AnalysisSummaryColor

@ijm8710
Copy link

ijm8710 commented Feb 28, 2025

Hell yeah! How about also adding proper coloring for wins/losses for the variant stat pages and also for win/loss streaks (as mobile web does)

See #819

@ijm8710
Copy link

ijm8710 commented May 1, 2025

@veloce are you willing to approve this or is there something you are awaiting

@veloce
Copy link
Contributor

veloce commented May 2, 2025

I'm not sure about this one. Since the app can have custom backgrounds, text may not be readable because of the colors.

@ijm8710
Copy link

ijm8710 commented Jun 24, 2025

I'm not sure about this one. Since the app can have custom backgrounds, text may not be readable because of the colors.

Hey Veloce, how would this be any different than:

  • the text being colored with analysis board once computer analysis is run for blunders/mistakes/inaccuracies (where I haven't seen any readability tickets posted)
  • Or even how tournament icons are colored.

You know how recent games list, the boxed list of games is in a box that's slightly color-offset from the rest of the background. Would that help?
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants