Skip to content

Conversation

@ztravis
Copy link

@ztravis ztravis commented Aug 16, 2024

I think this is a bug - the result variable is used for the result of this initial computation but isn't cleared afterwards. If the subsequent traversal fails to find a leaf node, it's possible for it to return this old value.

@codecov
Copy link

codecov bot commented Aug 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 14.99%. Comparing base (2b160d2) to head (aa176c7).

Files Patch % Lines
libpff/libpff_local_descriptors.c 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (2b160d2) and HEAD (aa176c7). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (2b160d2) HEAD (aa176c7)
4 2
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #133      +/-   ##
==========================================
- Coverage   23.66%   14.99%   -8.67%     
==========================================
  Files          63       63              
  Lines       20608    20609       +1     
  Branches     4966     4966              
==========================================
- Hits         4876     3091    -1785     
- Misses      14615    16989    +2374     
+ Partials     1117      529     -588     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant